Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): ethereumjs-util@6.1.0->^7.1.5 #11932

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix(deps): ethereumjs-util@6.1.0->^7.1.5 #11932

wants to merge 8 commits into from
+62 −127

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 21, 2024 •
edited
Loading

Description

Bump deprecated dependencies to (still deprecated but) lated versions with various fixes and improvements:

  • fix: unpin and update ethereumjs-util from 6.1.0 to ^7.1.5
  • fix: update ethereumjs-abi from 0.6.6 to ^0.6.8
    • Replace previous github resolution with version published on npm registry

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat mentioned this pull request Oct 21, 2024
Closed
@socket-security Socket Security
Copy link

socket-security bot commented Oct 21, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/file-uri-to-path@1.0.0

View full report↗︎

This was referenced Oct 21, 2024
Closed
Merged
@legobeat legobeat added team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@legobeat legobeat changed the title deps: ethereumjs-util@6.1.0->^7.1.5 fix(deps): ethereumjs-util@6.1.0->^7.1.5 Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5afd1f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b31b97e-d124-4151-bb21-342373de43ee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

legobeat
legobeat commented Oct 21, 2024
View reviewed changes
app/store/migrations/029.ts Outdated
@@ -466,7 +465,7 @@ export default async function migrate(stateAsync: unknown) {
if (Array.isArray(transactionControllerState.transactions)) {
transactionControllerState.transactions.forEach(
(transaction: TransactionParams, index: number) => {
if (transaction && !isHexString(transaction.chainId)) {
if (transaction && !transaction.chainId || (transaction.chainId && !isHexString(transaction.chainId))) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not change the resulting logic and is just validating transaction.chainId to account for that isHexString does not accept arbitrary input.

I am not sure if it is correct and intended that this should evaluate to true when transaction.chainId is undefined (or otherwise not sane to pass to toHex), or if explicit handling for that should actually be added.

@legobeat legobeat changed the base branch from main to ellul/resolve-secp256k1 October 21, 2024 23:56
@legobeat legobeat mentioned this pull request Oct 22, 2024
Open
4 tasks
Base automatically changed from ellul/resolve-secp256k1 to main October 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-lavamoat team-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @NicholasEllul